Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix configuration of lerna-changelog #7803

Merged
merged 2 commits into from
Apr 27, 2018
Merged

Conversation

shirohana
Copy link
Contributor

Q A
Fixed Issues? ✖️
Patch: Bug Fix?
Major: Breaking Change? ✖️
Minor: New Feature? ✖️
Tests Added + Pass? ✖️ (No test added)
Documentation PR ✖️
Any Dependency Changes? ✖️
License MIT

The cacheDir option should be scoped in "changelog" property, or it'll do nothing 😅

https://github.com/lerna/lerna-changelog#configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Apr 25, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7716/

@shirohana
Copy link
Contributor Author

Wait a second! I'm updating .gitignore and Makefile which forgotten

@shirohana
Copy link
Contributor Author

shirohana commented Apr 25, 2018

Tests failed, strange... 🤔

By the way,

Babel was using lerna@2.0.0 which configure commands.publish.ignore like:

"commands": {
  "publish": {
    "ignore": [
      "ignored-file",
      "*.md"
    ]
  }
}

https://github.com/lerna/lerna/tree/v2.0.0#lernajson

but in lerna@^3.0.0:

"command": {
  "publish": {
    "ignoreChanges": [
      "ignored-file",
      "*.md"
    ]
  }
}

https://github.com/lerna/lerna#lernajson

Just remind when upgrading in future (๑ơ ω ơ)

@shirohana
Copy link
Contributor Author

Excuse me 😅

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, my bad! (and I made that package originally lol)

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Apr 27, 2018
@hzoo hzoo merged commit b28ffed into babel:master Apr 27, 2018
@shirohana
Copy link
Contributor Author

Thanks ⸗‵ ᴗ ‵⸗

@shirohana shirohana deleted the fix/lerna-conf branch April 27, 2018 02:55
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants