Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename decorators&decorators2 plugins to decorators-legacy&decorators. #7821

Merged
merged 3 commits into from May 10, 2018

Conversation

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Apr 26, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change? Yes
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Reasons:

  1. Naming consistency with Babel plugins
  2. Sooner or later the decorators2 plugin should become decorators
Reasons:
1) Naming consistency with Babel plugins
2) Sooner or later the decorators2 plugin should become decorators
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 26, 2018
1 of 2 tasks complete
@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Apr 26, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7771/

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Apr 26, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7770/

@diervo
diervo approved these changes Apr 27, 2018
@diervo

This comment has been minimized.

Copy link
Contributor

diervo commented Apr 27, 2018

@nicolo-ribaudo @hzoo Have you guys decided wether decorators will be one single plugin or would we still apply the syntax enablement separately?

If so, we can certainly simplify the code on both babili and babel. Also we can remove the old "property" nomenclature toward fields

@xtuc
xtuc approved these changes May 9, 2018
@nicolo-ribaudo

This comment has been minimized.

Copy link
Member Author

nicolo-ribaudo commented May 10, 2018

@diervo They will stay separate, until we can remove the legacy version (probably in Babel 8?)

@nicolo-ribaudo nicolo-ribaudo merged commit 25c3f0d into babel:master May 10, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.8% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@nicolo-ribaudo nicolo-ribaudo deleted the nicolo-ribaudo:decorators-legacy-babylon branch May 10, 2018
@hzoo

This comment has been minimized.

Copy link
Member

hzoo commented May 10, 2018

This is the versioning issue we have been discussing. I think if we drop the stage 0-2 presets we should think about independent versioning for proposals and maybe keep them at 0.x. too many ideas/possibilities for that though

@lock lock bot added the outdated label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.