Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename decorators&decorators2 plugins to decorators-legacy&decorators. #7821

Merged
merged 3 commits into from
May 10, 2018
Merged

Rename decorators&decorators2 plugins to decorators-legacy&decorators. #7821

merged 3 commits into from
May 10, 2018

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change? Yes
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Reasons:

  1. Naming consistency with Babel plugins
  2. Sooner or later the decorators2 plugin should become decorators

@nicolo-ribaudo
Rename decorators&decorators2 plugins to decorators-legacy&decorators.
655cb6d 
Reasons:
1) Naming consistency with Babel plugins
2) Sooner or later the decorators2 plugin should become decorators
@nicolo-ribaudo nicolo-ribaudo added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release pkg: parser labels Apr 26, 2018
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 26, 2018
Closed
2 tasks
@babel-bot
Copy link
Collaborator

babel-bot commented Apr 26, 2018 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7771/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7770/

@diervo
Copy link
Contributor

diervo commented Apr 27, 2018 •
edited
Loading

@nicolo-ribaudo @hzoo Have you guys decided wether decorators will be one single plugin or would we still apply the syntax enablement separately?

If so, we can certainly simplify the code on both babili and babel. Also we can remove the old "property" nomenclature toward fields

@nicolo-ribaudo
Copy link
Member Author

@diervo They will stay separate, until we can remove the legacy version (probably in Babel 8?)

@nicolo-ribaudo nicolo-ribaudo merged commit 25c3f0d into babel:master May 10, 2018
@nicolo-ribaudo nicolo-ribaudo deleted the decorators-legacy-babylon branch May 10, 2018 18:01
@existentialism existentialism mentioned this pull request May 10, 2018
Merged
@hzoo
Copy link
Member

hzoo commented May 10, 2018 •
edited
Loading

This is the versioning issue we have been discussing. I think if we drop the stage 0-2 presets we should think about independent versioning for proposals and maybe keep them at 0.x. too many ideas/possibilities for that though

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 5, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@diervo diervo diervo approved these changes

@xtuc xtuc xtuc approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@nicolo-ribaudo @babel-bot @diervo @hzoo @existentialism @xtuc