fix(transform-typescript): do not elide injected imports #7833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7799/ |
|
will take a look at failing tests asap |
jeysal
force-pushed
the
transform-typescript-do-not-elide-injected-import
branch
from
0922811
to
86516eb
Compare
|
Fixed the tests on node 6 by removing ES2017 trailing commas from function calls in the test's |
|
@loganfsmyth mind reviewing this (or delegating to someone else)? I think this is the solution you had in mind. |
|
Anyone else? @nicolo-ribaudo? |
existentialism
added
PR: Bug Fix 🐛
ghost
approved these changes
May 9, 2018
existentialism
approved these changes
May 9, 2018
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #7830 (comment)