Refactor babel-cli to use async functions for async handling, and centralize option loading #7929
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganfsmyth
added
the
PR: Internal 🏠
loganfsmyth
force-pushed
the
cli-refactoring
branch
from
e59df96
to
beab6a1
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7964/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7960/ |
loganfsmyth
force-pushed
the
cli-refactoring
branch
from
beab6a1
to
8ff675a
Compare
existentialism
approved these changes
May 17, 2018
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some refactoring. Only functionality change I was was that if you give it a folder to compile with nothing in it, it will now say it compiled 0 files, instead of printing nothing, which was easier than the old behavior with the new implementation, and also makes more sense anyway.
Also bumped to 6.9 since that is the Node LTS, not 6 in general.