Update syntax-decorators options #7938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolo-ribaudo
commented
May 15, 2018
•
nicolo-ribaudo
commented
- Add decoratorsBeforeExport to the syntax plugin
- Require legacy: true, like in the transform plugin
| Q | A |
|---|---|
| Fixed Issues? | |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR | |
| Any Dependency Changes? | |
| License | MIT |
- Tests (I will enable them in Add support for the new decorators proposal #7976, since currently legacy must be true)
nicolo-ribaudo
added
PR: Breaking Change 💥
nicolo-ribaudo
commented
May 15, 2018
|
|
||
| ### `decoratorsBeforeExport` | ||
|
|
||
| `boolean`, defaults to `false`. |
There was a problem hiding this comment.
We might need to change the default value after the tc39 meeting
nicolo-ribaudo
force-pushed
the
decorators-before-export-syntax
branch
from
c445aff
to
e3cdb7c
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8245/ |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/7976/ |
4 tasks
existentialism
approved these changes
May 18, 2018
nicolo-ribaudo
commented
May 18, 2018
| This option allows developers to experimet both the possible syntaxes. This will | ||
| allow collecting an informed feedback from the community, which will help to | ||
| decide which the final syntax should be. | ||
| [tc39/proposal-decorators#69](https://github.com/tc39/proposal-decorators/issues/69) |
There was a problem hiding this comment.
@littledan Is this description ok?
There was a problem hiding this comment.
Maybe:
This option was added to help tc39 collect feedback from the community by allowing experimentation with both possible syntaxes.
For more information, check out: tc39/proposal-decorators#69
nicolo-ribaudo
force-pushed
the
decorators-before-export-syntax
branch
from
da8e262
to
d181894
Compare
* Add decoratorsBeforeExport to the syntax plugin * Require legacy: true, like in the transform plugin
nicolo-ribaudo
force-pushed
the
decorators-before-export-syntax
branch
from
d181894
to
638d365
Compare
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.