add jsesc options support #8143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vincentdchan
commented
Jun 11, 2018
vincentdchan
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #8124 |
| Patch: Bug Fix? | No |
| Major: Breaking Change? | No |
| Minor: New Feature? | Yes |
| Tests Added + Pass? | No |
| Documentation PR | No |
| Any Dependency Changes? | No |
| License | MIT |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8350/ |
| jsescOption: { | ||
| quotes: "double", | ||
| wrap: true, | ||
| ...(opts.jsescOption || {}), |
There was a problem hiding this comment.
|| {} isn't needed; object spread works with null/undefined/false
nicolo-ribaudo
approved these changes
Jun 11, 2018
hzoo
added
the
PR: New Feature 🚀
This was referenced Jun 15, 2018
|
I realize that with this change we can just remove the Instead users can do Also I realize this could be plural haha.. |
|
@hzoo Of cause it can, but it would be a breaking change, I don't know if babel can accept it? |
This was referenced May 4, 2019
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.