Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce objectWithoutPropertiesLoose helper #8261

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Introduce objectWithoutPropertiesLoose helper #8261

merged 1 commit into from
Jul 6, 2018

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Jul 4, 2018 •
edited
Loading

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? x
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Just a shorter version (without symbol handling) of objectWithoutProperties helper - for loose mode

@Andarist Andarist added PR: New Feature 🚀 A type of pull request used for our changelog categories area: helpers labels Jul 4, 2018
@TrySound
Copy link
Contributor

TrySound commented Jul 4, 2018

Can extends be renamed to objectSpreadLoose for consistency?

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 4, 2018 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8486/

@Andarist
Copy link
Member Author

Andarist commented Jul 4, 2018

Yeah, it could be - don't see any downside of this. That would have to be done in a separate PR though.

nicolo-ribaudo
nicolo-ribaudo reviewed Jul 4, 2018
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you could replace lines 604-612 of the objectWithoutProperties helper with

var target = objectWithoutPropertiesLoose(source, excluded);

?

@Andarist Andarist force-pushed the loose/without-properties-helper branch from 75206e8 to e01e2cc Compare July 4, 2018 18:31
@Andarist
Copy link
Member Author

Andarist commented Jul 4, 2018

@nicolo-ribaudo good idea 👍 done

@Andarist
Copy link
Member Author

Andarist commented Jul 4, 2018

@TrySound actually I've realized now that this particular helper (extends) is used in other contexts too, so renaming it to objectSpreadLoose would actually make it confusing.

@TrySound TrySound mentioned this pull request Jul 5, 2018
Closed
@hzoo hzoo merged commit c0c13ae into babel:master Jul 6, 2018
NMinhNguyen pushed a commit to NMinhNguyen/babel-plugin-transform-destructuring that referenced this pull request Aug 9, 2019
@Andarist @hzoo
Introduce objectWithoutPropertiesLoose helper (babel#8261)
1c649be
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

Assignees
No one assigned
Labels
area: helpers outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Andarist @TrySound @babel-bot @nicolo-ribaudo @hzoo