Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce objectWithoutPropertiesLoose helper #8261

Merged
merged 1 commit into from Jul 6, 2018

Conversation

@Andarist
Copy link
Member

Andarist commented Jul 4, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? x
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Just a shorter version (without symbol handling) of objectWithoutProperties helper - for loose mode

@TrySound

This comment has been minimized.

Copy link
Contributor

TrySound commented Jul 4, 2018

Can extends be renamed to objectSpreadLoose for consistency?

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jul 4, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8486/

@Andarist

This comment has been minimized.

Copy link
Member Author

Andarist commented Jul 4, 2018

Yeah, it could be - don't see any downside of this. That would have to be done in a separate PR though.

Copy link
Member

nicolo-ribaudo left a comment

Maybe you could replace lines 604-612 of the objectWithoutProperties helper with

var target = objectWithoutPropertiesLoose(source, excluded);

?

@Andarist Andarist force-pushed the Andarist:loose/without-properties-helper branch from 75206e8 to e01e2cc Jul 4, 2018
@Andarist

This comment has been minimized.

Copy link
Member Author

Andarist commented Jul 4, 2018

@nicolo-ribaudo good idea 👍 done

@Andarist

This comment has been minimized.

Copy link
Member Author

Andarist commented Jul 4, 2018

@TrySound actually I've realized now that this particular helper (extends) is used in other contexts too, so renaming it to objectSpreadLoose would actually make it confusing.

@hzoo hzoo merged commit c0c13ae into babel:master Jul 6, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.73% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
NMinhNguyen pushed a commit to NMinhNguyen/babel-plugin-transform-destructuring that referenced this pull request Aug 9, 2019
@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.