Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused bindings when excluding keys with rest in loose mode #8264

Merged
merged 1 commit into from
Jul 7, 2018

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Jul 4, 2018

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change? somewhat?
Minor: New Feature? x
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

Rest operator is often used as omit-like util. It seems to me that knowing that we can remove unused bindings to generate shorter code (in loose mode only as in theory there could be some getters on destructured object).

@Andarist Andarist added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Jul 4, 2018
@Andarist Andarist force-pushed the loose/remove-unused-excluded-keys branch from e18a6c7 to 78814f3 Compare July 4, 2018 19:27
@babel-bot
Copy link
Collaborator

babel-bot commented Jul 4, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8488/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea!

@Andarist Andarist merged commit b5e64cb into babel:master Jul 7, 2018
@Andarist Andarist deleted the loose/remove-unused-excluded-keys branch July 7, 2018 17:54
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants