Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages around pipeline option #8279

Merged
merged 1 commit into from Jul 6, 2018

Conversation

@mAAdhaTTah
Copy link
Contributor

mAAdhaTTah commented Jul 6, 2018

Q                       A
Fixed Issues? Fixes #8276, #8277
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link N/A
Any Dependency Changes? N/A
License MIT

Improve the error messages so we (hopefully) get fewer issues about this.

Thoughts about linking to the docs in the error message? Good or bad idea?

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jul 6, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8526/

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Jul 6, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8513/

Copy link
Member

nicolo-ribaudo left a comment

Thoughts about linking to the docs in the error message?

👍

" You must pass the 'pipelineProposal' option to" +
" @babel/preset-stage-0",
" You must pass 'pipelineProposal' option to" +
" @babel/preset-stage-0 with one of: " +

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Jul 6, 2018

Member

with -> whose value must be

@mAAdhaTTah mAAdhaTTah force-pushed the valtech-nyc:improve-pipeline-error-messages branch from 2f3dd14 to 4cd87d6 Jul 6, 2018
@mAAdhaTTah

This comment has been minimized.

Copy link
Contributor Author

mAAdhaTTah commented Jul 6, 2018

Updated!

"The pipeline operator plugin requires a 'proposal' option." +
"'proposal' must be one of: " +
proposals.join(", ") +
". More details: https://babeljs.io/docs/en/next/babel-plugin-syntax-pipeline-operator.html",

This comment has been minimized.

Copy link
@hzoo

hzoo Jul 6, 2018

Member

I think you want to link to https://babeljs.io/docs/en/next/babel-plugin-proposal-pipeline-operator? If not, then we need the doc in the syntax plugin, and you can remove the .html now

This comment has been minimized.

Copy link
@mAAdhaTTah

mAAdhaTTah Jul 6, 2018

Author Contributor

Whoops, fixed.

@mAAdhaTTah mAAdhaTTah force-pushed the valtech-nyc:improve-pipeline-error-messages branch from 4cd87d6 to db9819d Jul 6, 2018
@hzoo hzoo merged commit f93fa28 into babel:master Jul 6, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.71% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@mAAdhaTTah mAAdhaTTah deleted the valtech-nyc:improve-pipeline-error-messages branch Jul 7, 2018
@mengli404

This comment has been minimized.

Copy link

mengli404 commented Jul 7, 2018

@mAAdhaTTah after this branch merged to master, my error message still like this:

Build failed: [BABEL] /Users/mengliding/Documents/front_end_repo/network-map/.webpackrc.js: 'proposal' must be one of: minimal (While processing: "/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_plugin-proposal-pipeline-operator@7.0.0-beta.52@@babel/plugin-proposal-pipeline-operator/lib/index.js$inherits")
Error: [BABEL] /Users/mengliding/Documents/front_end_repo/network-map/.webpackrc.js: 'proposal' must be one of: minimal (While processing: "/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_plugin-proposal-pipeline-operator@7.0.0-beta.52@@babel/plugin-proposal-pipeline-operator/lib/index.js$inherits")
    at _default (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_plugin-syntax-pipeline-operator@7.0.0-beta.52@@babel/plugin-syntax-pipeline-operator/lib/index.js:26:11)
    at /Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_helper-plugin-utils@7.0.0-beta.52@@babel/helper-plugin-utils/lib/index.js:19:12
    at loadDescriptor (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:157:14)
    at cachedFunction (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/caching.js:32:19)
    at loadPluginDescriptor (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:192:28)
    at cache.invalidate.data (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:216:47)
    at CacheConfigurator.invalidate (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/caching.js:149:17)
    at instantiatePlugin (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:216:28)
    at cachedFunction (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/caching.js:32:19)
    at loadPluginDescriptor (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:192:10)
    at config.plugins.map.descriptor (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:68:16)
    at Array.map (<anonymous>)
    at recurseDescriptors (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:67:38)
    at recurseDescriptors (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:86:27)
    at recurseDescriptors (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:86:27)
    at loadFullConfig (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:100:6)
@nicolo-ribaudo

This comment has been minimized.

Copy link
Member

nicolo-ribaudo commented Jul 7, 2018

Can you try to redownload and rebuild the repo?

@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
6 participants
You can’t perform that action at this time.