Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages around pipeline option #8279

Merged
merged 1 commit into from
Jul 6, 2018
Merged

Improve error messages around pipeline option #8279

merged 1 commit into from
Jul 6, 2018

Conversation

mAAdhaTTah
Copy link
Contributor

@mAAdhaTTah mAAdhaTTah commented Jul 6, 2018 •
edited by hzoo
Loading

Q                       A
Fixed Issues? Fixes #8276, #8277
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link N/A
Any Dependency Changes? N/A
License MIT

Improve the error messages so we (hopefully) get fewer issues about this.

Thoughts about linking to the docs in the error message? Good or bad idea?

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 6, 2018 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8526/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8513/

nicolo-ribaudo
nicolo-ribaudo reviewed Jul 6, 2018
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts about linking to the docs in the error message?

👍

packages/babel-preset-stage-0/src/index.js Outdated
" You must pass the 'pipelineProposal' option to" +
" @babel/preset-stage-0",
" You must pass 'pipelineProposal' option to" +
" @babel/preset-stage-0 with one of: " +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with -> whose value must be

@mAAdhaTTah mAAdhaTTah force-pushed the improve-pipeline-error-messages branch from 2f3dd14 to 4cd87d6 Compare July 6, 2018 13:55
@mAAdhaTTah
Copy link
Contributor Author

Updated!

@existentialism existentialism added the PR: Polish 💅 A type of pull request used for our changelog categories label Jul 6, 2018
hzoo
hzoo reviewed Jul 6, 2018
View reviewed changes
packages/babel-plugin-syntax-pipeline-operator/src/index.js Outdated
"The pipeline operator plugin requires a 'proposal' option." +
"'proposal' must be one of: " +
proposals.join(", ") +
". More details: https://babeljs.io/docs/en/next/babel-plugin-syntax-pipeline-operator.html",
Copy link
Member

@hzoo hzoo Jul 6, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you want to link to https://babeljs.io/docs/en/next/babel-plugin-proposal-pipeline-operator? If not, then we need the doc in the syntax plugin, and you can remove the .html now

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, fixed.

@mAAdhaTTah mAAdhaTTah force-pushed the improve-pipeline-error-messages branch from 4cd87d6 to db9819d Compare July 6, 2018 14:17
@hzoo hzoo merged commit f93fa28 into babel:master Jul 6, 2018
@mAAdhaTTah mAAdhaTTah deleted the improve-pipeline-error-messages branch July 7, 2018 00:46
@mengli404
Copy link

@mAAdhaTTah after this branch merged to master, my error message still like this:

Build failed: [BABEL] /Users/mengliding/Documents/front_end_repo/network-map/.webpackrc.js: 'proposal' must be one of: minimal (While processing: "/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_plugin-proposal-pipeline-operator@7.0.0-beta.52@@babel/plugin-proposal-pipeline-operator/lib/index.js$inherits")
Error: [BABEL] /Users/mengliding/Documents/front_end_repo/network-map/.webpackrc.js: 'proposal' must be one of: minimal (While processing: "/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_plugin-proposal-pipeline-operator@7.0.0-beta.52@@babel/plugin-proposal-pipeline-operator/lib/index.js$inherits")
    at _default (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_plugin-syntax-pipeline-operator@7.0.0-beta.52@@babel/plugin-syntax-pipeline-operator/lib/index.js:26:11)
    at /Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_helper-plugin-utils@7.0.0-beta.52@@babel/helper-plugin-utils/lib/index.js:19:12
    at loadDescriptor (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:157:14)
    at cachedFunction (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/caching.js:32:19)
    at loadPluginDescriptor (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:192:28)
    at cache.invalidate.data (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:216:47)
    at CacheConfigurator.invalidate (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/caching.js:149:17)
    at instantiatePlugin (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:216:28)
    at cachedFunction (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/caching.js:32:19)
    at loadPluginDescriptor (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:192:10)
    at config.plugins.map.descriptor (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:68:16)
    at Array.map (<anonymous>)
    at recurseDescriptors (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:67:38)
    at recurseDescriptors (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:86:27)
    at recurseDescriptors (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:86:27)
    at loadFullConfig (/Users/mengliding/Documents/front_end_repo/network-map/node_modules/_@babel_core@7.0.0-beta.52@@babel/core/lib/config/full.js:100:6)

@nicolo-ribaudo
Copy link
Member

Can you try to redownload and rebuild the repo?

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@hzoo hzoo hzoo left review comments

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo left review comments

@existentialism existentialism existentialism approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"The pipeline operator requires a proposal set error" during compile
6 participants
@mAAdhaTTah @babel-bot @mengli404 @nicolo-ribaudo @existentialism @hzoo