Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove our own use of stage presets #8397

Merged
merged 3 commits into from
Jul 28, 2018
Merged

Remove our own use of stage presets #8397

merged 3 commits into from
Jul 28, 2018

Conversation

hzoo
Copy link
Member

@hzoo hzoo commented Jul 27, 2018 •
edited
Loading

  • update the stage preset error message/readme's to point to the new blog post (someone else can do this if you want)

@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Jul 27, 2018
hzoo
hzoo commented Jul 27, 2018
View reviewed changes
package.json Outdated
"@babel/plugin-proposal-class-properties": "7.0.0-beta.52",
"@babel/plugin-proposal-export-namespace-from": "7.0.0-beta.52",
"@babel/plugin-proposal-numeric-separator": "7.0.0-beta.52",
"@babel/plugin-proposal-object-rest-spread": "7.0.0-beta.52",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually we can probably remove since it's part of preset-env?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep

@babel-bot
Copy link
Collaborator

babel-bot commented Jul 27, 2018 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8717/

@hzoo hzoo merged commit fa86b2d into master Jul 28, 2018
@xtuc xtuc deleted the rm-stage-preset-use branch July 28, 2018 16:25
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism left review comments

@xtuc xtuc xtuc approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@hzoo @babel-bot @existentialism @xtuc @nicolo-ribaudo