Babel cli fix recursion in file mode #8418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8757/ |
hzoo
pushed a commit
that referenced
this pull request
Aug 8, 2018
PR #8418 introduced some new logic that uses the third parameter of `fs-readdir-recursive`'s `filter` option, the current directory, but missed that our dependencies only required `^1.0.0`, while that parameter was actually added in `1.1.0`. This means that if some other dependency forced a downgrade in the version to satisfy some range, or the user already had 1.0.0 module installed locally, it could cause problems,
|
ah, damn, sorry about that. Was working with my current freshly installed env so didn't catch that one. Is there actually a way to install all minimal versions of required packages to test something like that? |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
While using babel-cli in file mode and passing it a folder to recurse throu (e.g.
babel src --out-file test.js) it just scans for all files in the provided directory but does not recurse into it's subdirectories.Currently it uses an extension filter that is applied to all folder elements before processing. But the extension filter doesn't exclude directories from filtering.
This results in unexpected behaviour because it would recurse into folders that would have an extension, but not in those who don't. And concerning the documentation and its behaviour in its previous version, it should recurse into all directories.
How
The PR adds an additional check to the recurse filter and accepts all directories.