-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Require decoratorsBeforeExport option for decorators #8465
Require decoratorsBeforeExport option for decorators #8465
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8809/ |
|
||
it("when they aren't specified", function() { | ||
// Currently every option is required, so this can't be tested. | ||
it.skip("when they aren't specified", function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can just remove this dead code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I forgot about flow's all
option 😆 I re-enabled the test using it.
This change makes no sense, |
Are you using Babel or the parser? They have slightly different options:
|
Ah okay thanks for the pointer. ImportJS seems to be using the parser directly |
It has not been decided yet where decorators should go.