Make 'useESModules' only toggle CJS vs ESM helpers when importing file is ESM. #8518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganfsmyth
added
the
PR: Breaking Change 💥
suchipi
approved these changes
Aug 23, 2018
loganfsmyth
force-pushed
the
runtime-cjs-force
branch
from
76bc988
to
de938e1
Compare
existentialism
approved these changes
Aug 23, 2018
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8895/ |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed this as a potential issue. If a file is a CJS file where we're just going to
requirethe helper, we definitely don't want that helper to be one of the ESM helpers, since it's not at all clear that it will be possible torequirean ESM file in the long run, and that could promote a bad pattern.This is technically breaking, but most people don't even know
useESModulesis a thing, and those that do are almost certainly already disabling the CJS transform.