Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix version badges in monorepo README #8534

Merged
merged 2 commits into from Sep 3, 2018
Merged

Conversation

Simek
Copy link
Contributor

@Simek Simek commented Aug 25, 2018

Badges caching disabled by removing the maxAge parameter from image URLs to ensure that always the latest version of package is displayed.

Badges caching disabled by removing the maxAge parameter from image URLs to ensure that always the latest version of package is displayed.
@babel-bot
Copy link
Collaborator

babel-bot commented Aug 25, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8989/

@nicolo-ribaudo
Copy link
Member

Maybe we could set it to one day (86400 seconds)?

@loganfsmyth
Copy link
Member

Badges caching disabled by removing the maxAge parameter

Is that true? https://shields.io/ makes it seem like it will default to 120 seconds when left off.

Given that 2592000 is in seconds, that does seem extremely high, but 120 seems unnecessarily fast. Maybe just say an hour or something (3600)?

@Simek
Copy link
Contributor Author

Simek commented Sep 3, 2018

I have missed the default value of cache time on Shields.io, my bad, sorry.

One hour seems reasonable for me, and sounds better than default 120s.

PR has been updated, but if you finally decide to extend cache to one day just let me know here.

@loganfsmyth loganfsmyth merged commit ffc8237 into babel:master Sep 3, 2018
@loganfsmyth
Copy link
Member

Thanks!

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants