class private methods and properties: should not allow spaces between # and identifier

[macabeus]

Following babel/proposals#12 (comment), we should not allow spaces between # and identifier.
But, since we currently allow it, this fix is a breaking change.

Q	A
Fixed Issues?	Fixes #8225
Patch: Bug Fix?	Yes
Major: Breaking Change?	Yes
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

[babel-bot]

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9179/

[nicolo-ribaudo]

This is not going to work well with the pipeline proposal, since it uses a # which can be followed by a space.
Maybe we can move the whitespace check to the parser method which parser private names?

[macabeus]

@nicolo-ribaudo I made a rebase with a new commit fixing the problem that you said. Thank you.

Since the spaces are skipped at tokenizer, then the identifier doesn't have the spaces, I need to use others informations at node to check it.

[loganfsmyth]

@nicolo-ribaudo Do you have a link for that?

[macabeus]

@loganfsmyth @nicolo-ribaudo Thank you. I made a new rebase following your suggestion, using this.state.pos before next() and this.state.start after it.

[nicolo-ribaudo]

Looks good!

[loganfsmyth]

Thanks!

[hzoo]

awesome work @macabeus!