Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preset-env: Edge support for arrow param destructuring #8926

Merged
merged 1 commit into from Oct 31, 2018

Conversation

@benmosher
Copy link
Contributor

benmosher commented Oct 24, 2018

Q                       A
Fixed Issues? Fixes #8349
Patch: Bug Fix? Yes
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? No tests added (only data changed), all tests passed locally
Documentation PR Link
Any Dependency Changes? No
License MIT

Added the as-yet-Edge-unsupported arrow function parameter destructuring as a feature supported by transform-parameters, per compat-table.

@babel-bot

This comment has been minimized.

Copy link
Collaborator

babel-bot commented Oct 24, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9282/

@benmosher

This comment has been minimized.

Copy link
Contributor Author

benmosher commented Oct 30, 2018

FWIW, I published this to npm as @benmosher/babel-preset-env@7.1.1

@existentialism

This comment has been minimized.

Copy link
Member

existentialism commented Oct 31, 2018

@benmosher thanks!

@existentialism existentialism merged commit c82750a into babel:master Oct 31, 2018
4 checks passed
4 checks passed
babel/repl REPL preview is available
Details
ci/circleci Your tests passed on CircleCI!
Details
codecov/project 80.6% (target 80%)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
mAAdhaTTah added a commit to valtech-nyc/babel that referenced this pull request Nov 3, 2018
* master: (222 commits)
  Set correct methods name
  Use toPropertyKey in the "decorate" helper
  Allow function types in type params within arrow return types (babel#8954)
  Fix message when plugin of a wrong type is passed (babel#8950)
  rename colliding let bindings with for loop init (babel#8937)
  edge incomplete support for arrow destructuring (babel babel#8349) (babel#8926)
  fix single-arg async arrows when retainLines=true (babel#8868)
  [flow] Explicit inexact objects with `...` (babel#8884)
  Update preset-env data (babel#8898)
  Treat break inside block inside loop (babel#8914)
  fixed "source map" formatting in comment (babel#8878) [skip ci]
  fix typo in contributing guidelines (babel#8901) [skip ci]
  fix: Expression x === 'y' && '' should not evaluate to undefined. (babel#8880)
  fixed an extra word
  Fixes babel#8865 (babel#8866)
  v7.1.4
  v7.1.3
  Bump Babel deps (babel#8770)
  flow-bin@0.82.0 (babel#8832)
  Insertafter jsx fix (babel#8833)
  ...

# Conflicts:
#	packages/babel-parser/src/tokenizer/index.js
#	packages/babel-parser/test/fixtures/experimental/class-private-properties/failure-numeric-literal/options.json
#	packages/babel-parser/test/fixtures/experimental/pipeline-operator/invalid-proposal/options.json
@JSteunou

This comment has been minimized.

Copy link

JSteunou commented Nov 13, 2018

@benmosher & @existentialism I think this PR introduced a regression, can you look at #9020 (comment) please ?

@JSteunou

This comment has been minimized.

Copy link

JSteunou commented Nov 13, 2018

Moreover Edge 17, 16 handles it (maybe more, I could not go back under)

@JSteunou

This comment has been minimized.

Copy link

JSteunou commented Nov 13, 2018

My bad, it supports it only if there are no previous parameters, issue is still valid

This is supported

(({b = 0, c = 3}) => {
  return b === 2 && c === 3;
})({b: 2});

this is not supported

((a, {b = 0, c = 3}) => {
  return a === 1 && b === 2 && c === 3;
})(1, {b: 2});```
@benmosher

This comment has been minimized.

Copy link
Contributor Author

benmosher commented Nov 28, 2018

@JSteunou is it possible to do the transpilation in a finer-grained way? AFAICT it's just the one plugin package that handles both fixing this issue but also has the _this = super() bug in #9020. I would think ideally the _this = super() would instead be something that works in Edge (e.g. #9060) but I am not especially Babel-literate 😕 .

@adrienharnay

This comment has been minimized.

Copy link

adrienharnay commented Dec 10, 2018

Hey, just ran into this. Using @babel/preset-env 7.1.6, and basically it outputs this using esmodules: true:

class User_User extends react_default.a.Component {
  constructor() {
    var _this;

    _this = super(...arguments);

    User_defineProperty(this, "onClick", () => {
      if (!this.props.user) {
        this.props.doSomething();
      }
    });

    User_defineProperty(this, "render", function () {
      let optionalArg = arguments.length > 0 && arguments[0] !== undefined ? arguments[0] : 'false';
      // this line crashes on Edge 17.1734 (latest at this moment)
      const _this$props = _this.props,
            user = _this$props.user;
    });
  }

  render() {
    const user = this.props.user;
    return react_default.a.createElement("div");
  }
}

Is there any work on this at the moment? Any workaround in the meantime?

Thanks in advance!

@lock lock bot added the outdated label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.