Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yield expression transform #9076

Merged
merged 1 commit into from
Nov 27, 2018
Merged

Fix yield expression transform #9076

merged 1 commit into from
Nov 27, 2018

Conversation

phapp88
Copy link
Contributor

@phapp88 phapp88 commented Nov 25, 2018

Q                       A
Fixed Issues? Fixes #9063
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This pull request prevents parentheses around a yield expression from being removed if the parent expression is an await expression.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9452/

@nicolo-ribaudo
Copy link
Member

Thank you!

@existentialism existentialism merged commit 2bb24f9 into babel:master Nov 27, 2018
@phapp88 phapp88 deleted the fix-yield-expression-transform branch December 4, 2018 14:52
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator Spec: Async Generators
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unexpected yield expression transform
4 participants