Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment objectSpread helper version #9381

Closed

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #9376, closes #9379
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo
Copy link
Member Author

nicolo-ribaudo commented Jan 22, 2019

This doesn't work, it's the opposite problem (old code using the new helper).
We should probably create a new objectSpread2 helper to introduce this breaking change.

@nicolo-ribaudo nicolo-ribaudo deleted the spread-regression branch January 22, 2019 06:55
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9855/

1 similar comment
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9855/

@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot convert undefined or null to object
2 participants