Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify reserved word checking and update error messages #9402

Merged
merged 2 commits into from
Feb 1, 2019
Merged

Unify reserved word checking and update error messages #9402

merged 2 commits into from
Feb 1, 2019

Conversation

danez
Copy link
Member

@danez danez commented Jan 23, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? (y)
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

When checking for reserved words we currently do multiple checks: isReservedWords, isReservedWordsStrict and isReservedWordsStrictBind
This all is actually one check, but the list of reserved words changes depending on the context defined by inModule, strict and isBinding

So what this PR simply does is make it unnecessary to check all the different types of reserved words and instead only check against ONE list of reserved words for non-strict, strict or strict-binding. All this list contain their previous list:

non-strict: [..]
strict: non-strict + [...]
strict-binding: strict + [...]

For performance this is good because we do only one lookup against one list instead of multiple lookups. The non-strict "list" is not really a list because it contains the logic for inModule. I could have multiplied this out and created more lists (non-strict, non-strict-in-module, strict, strict-in-module, strict-bind, strict-bin-in-module) but decided not to.

@danez danez added PR: Polish 💅 A type of pull request used for our changelog categories pkg: parser labels Jan 23, 2019
@danez danez added this to In progress in Parser: Spec Compliance, Refactoring and Performance via automation Jan 23, 2019
Parser: Spec Compliance, Refactoring and Performance automation moved this from In progress to Reviewed Jan 23, 2019
Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after fixing enum test failure

@babel-bot
Copy link
Collaborator

babel-bot commented Jan 24, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9956/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9899/

@danez danez merged commit 9eb010d into babel:master Feb 1, 2019
Parser: Spec Compliance, Refactoring and Performance automation moved this from Reviewed to Done Feb 1, 2019
@danez danez deleted the unify-reserved-words branch February 1, 2019 03:02
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Polish 💅 A type of pull request used for our changelog categories
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants