Unify reserved word checking and update error messages #9402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking for reserved words we currently do multiple checks:
isReservedWords
,isReservedWordsStrict
andisReservedWordsStrictBind
This all is actually one check, but the list of reserved words changes depending on the context defined by
inModule
,strict
andisBinding
So what this PR simply does is make it unnecessary to check all the different types of reserved words and instead only check against ONE list of reserved words for
non-strict
,strict
orstrict-binding
. All this list contain their previous list:For performance this is good because we do only one lookup against one list instead of multiple lookups. The non-strict "list" is not really a list because it contains the logic for
inModule
. I could have multiplied this out and created more lists (non-strict, non-strict-in-module, strict, strict-in-module, strict-bind, strict-bin-in-module
) but decided not to.