Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install polyfill & runtime to dependency instead of devDependency [skip ci] #9409

Merged
merged 3 commits into from Jan 29, 2019

Conversation

itsnotrisky
Copy link
Contributor

as per doc:

Q                       A
Fixed Issues? No
Patch: Bug Fix? No
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes? No
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented Jan 24, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9907/

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9906/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@existentialism
Copy link
Member

Note, we'll lose these changes if https://github.com/babel/babel/blob/master/scripts/generators/readmes.js ever gets run again.

@nicolo-ribaudo
Copy link
Member

Oh right, it needs to be special-cased in that script

@itsnotrisky
Copy link
Contributor Author

Thanks for mentioning the script, sorry did not realize one exists!

I'll try to play around with the script see what I can come up with. It's just got a long weekend down here.

@itsnotrisky
Copy link
Contributor Author

Managed to update the script so that it will print npm install --save package and yarn add package for @babel/polyfill and @babel/runtime.

Also found @babel/helper-create-class-features-plugin was written as @babel/plugin-class-features think that might be a typo?

@nicolo-ribaudo
Copy link
Member

Also found @babel/helper-create-class-features-plugin was written as @babel/plugin-class-features think that might be a typo?

Yeah, it was the old name.

@existentialism
Copy link
Member

@spondbob thanks!

@existentialism existentialism merged commit 56044c7 into babel:master Jan 29, 2019
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants