Typescript function destructured params #9431
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mhcgrq
commented
Jan 30, 2019
mhcgrq
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #9430 |
| Patch: Bug Fix? | Yes |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/9960/ |
| @@ -794,6 +795,21 @@ export default (superClass: Class<Parser>): Class<Parser> => | |||
| return true; | |||
| } | |||
|
|
|||
| if (this.match(tt.bracketL)) { | |||
There was a problem hiding this comment.
The two checks should be merged, since there could be code like this:
type Foo = ([{a}]: any) => {};There was a problem hiding this comment.
Currently it just works for [a] {a} and [{a}]. Is that neccesary to check brace and bracket within a same if block? Since there is only brace and bracket, no more conditions.
There was a problem hiding this comment.
I understood why this already works
nicolo-ribaudo
added
PR: Bug Fix 🐛
nicolo-ribaudo
approved these changes
Feb 7, 2019
| @@ -794,6 +795,21 @@ export default (superClass: Class<Parser>): Class<Parser> => | |||
| return true; | |||
| } | |||
|
|
|||
| if (this.match(tt.bracketL)) { | |||
There was a problem hiding this comment.
I understood why this already works
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.