Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minify bundles on circle for repl #9582

Merged
merged 1 commit into from Feb 25, 2019
Merged

Minify bundles on circle for repl #9582

merged 1 commit into from Feb 25, 2019

Conversation

danez
Copy link
Member

@danez danez commented Feb 25, 2019

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix? y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Seems I did not think of that the bundles build on circle are used in the repl. So currently the min bundle is not minified.

@danez danez added the PR: Internal 🏠 A type of pull request used for our changelog categories label Feb 25, 2019
@danez
Copy link
Member Author

danez commented Feb 25, 2019

The push failed, well because I did not push to this repo but my fork. 🤔

@nicolo-ribaudo
Copy link
Member

That's strange 🤔 I have always only pushed to my fork

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10269/

@buildsize
Copy link

buildsize bot commented Feb 25, 2019 •
edited

File name Previous Size New Size Change
babel-preset-env.js 2.02 MB 2.02 MB 8 bytes (0%)
babel-preset-env.min.js 2.02 MB 1.08 MB -957.84 KB (46%)
babel.js 2.74 MB 2.74 MB 8 bytes (0%)
babel.min.js 2.74 MB 1.53 MB -1.21 MB (44%)

@danez
Copy link
Member Author

danez commented Feb 25, 2019 •
edited

What should the threshold be for the buildsize comment?

Currently buildsize will comment on PRs when the bundles change for more than or equal to 750 Bytes, which is a little bit low I think.

@nicolo-ribaudo
Copy link
Member

10 kB? It should catch regressions like duplicate packages while not firing for most PRs

@danez
Copy link
Member Author

danez commented Feb 25, 2019

Okay will change.

@danez danez merged commit 632552f into babel:master Feb 25, 2019
@danez danez deleted the minify-on-circle branch February 25, 2019 19:52
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danez @nicolo-ribaudo @babel-bot