Correctly parse TS TypeAssertions around arrow functions #9699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danez
added
the
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10517/ |
nicolo-ribaudo
approved these changes
Mar 18, 2019
existentialism
approved these changes
Mar 18, 2019
armano2
reviewed
Mar 20, 2019
| @@ -0,0 +1,4 @@ | |||
| { | |||
| "createParenthesizedExpressions": true, | |||
There was a problem hiding this comment.
@nicolo-ribaudo, @existentialism should we add this option to babel-plugin-syntax-typescript?
There was a problem hiding this comment.
No this is only for tools using babel-parser directly.
Babel would not understand the AST that gets returned when this option is active.
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change it would only work if
createParenthesizedExpressionswas true, because we already check if the node is not anArrowFunctionExpression. Now it also works with this setting set to false.