Tweak preset-env corejs/useBuiltIns warning and error messages #9716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
existentialism
commented
Mar 20, 2019
existentialism
commented
| Q | A |
|---|---|
| Fixed Issues? | |
| Patch: Bug Fix? | N |
| Major: Breaking Change? | N |
| Minor: New Feature? | N |
| Tests Added + Pass? | Y/Y |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
existentialism
added
PR: Polish 💅
existentialism
force-pushed
the
env-warnings
branch
from
558a71c
to
6b0a1bb
Compare
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10556/ |
| "core-js version. Currently, we assume version 2.x when no version " + | ||
| "is passed. Since this default version will likely change in future " + | ||
| "versions of Babel, we recommend explicitly setting the core-js version " + | ||
| "you are using via the `corejs` option.\n", |
There was a problem hiding this comment.
We should also say they users should be sure that they have the correct version of core-js in their dependencies.
For example, angular-cli was broken by the core-js@3 release because they were relying on core-js@2 being in node_modules without specifying it in dependencies.
There was a problem hiding this comment.
Suggested change
| "you are using via the `corejs` option.\n", | |
| "you are using via the `corejs` option.\n" + | |
| "You should also be sure that the version you pass to the `corejs` " + | |
| "option matches the version specified in your `package.json`'s " + | |
| "`dependencies` section. If it doesn't, you need to run one of the " + | |
| "following commands:\n\n" + | |
| " npm install --save core-js@2 npm install --save core-js@3\n" + | |
| " yarn add core-js@2 yarn add core-js@3\n", |
existentialism
force-pushed
the
env-warnings
branch
from
6b0a1bb
to
7fb4842
Compare
nicolo-ribaudo
approved these changes
Mar 20, 2019
danez
approved these changes
Mar 20, 2019
zloirock
approved these changes
Mar 20, 2019
|
The corejs mentioned in this new warning message is undocumented: https://babeljs.io/docs/en/babel-preset-env |
|
Doc PR at babel/website#1987 |
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.