Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modules might be in loose mode when checking for undecl exports #9725

Merged
merged 1 commit into from
Mar 21, 2019
Merged

Modules might be in loose mode when checking for undecl exports #9725

merged 1 commit into from
Mar 21, 2019

Conversation

nicolo-ribaudo
Copy link
Member

Q                       A
Fixed Issues? Fixes #9720
Patch: Bug Fix? yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser i: regression labels Mar 20, 2019
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10553/

1 similar comment
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10553/

@nicolo-ribaudo nicolo-ribaudo added this to the v7.4.2 milestone Mar 20, 2019
danez
danez approved these changes Mar 20, 2019
View reviewed changes
Copy link
Member

@danez danez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what the original usecase for the useStrict option was. Maybe in babel 8 we should throw if strict === false && module=== true.

@nicolo-ribaudo
Copy link
Member Author

Agree 👍

@danez danez merged commit 2201fd8 into babel:master Mar 21, 2019
@nicolo-ribaudo nicolo-ribaudo deleted the regression-9720 branch March 23, 2019 23:34
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Mar 23, 2019
Closed
@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Apr 14, 2019
Closed
@sebdeckers sebdeckers mentioned this pull request Apr 15, 2019
Closed
@snyk-bot snyk-bot mentioned this pull request Aug 20, 2019
Closed
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@danez danez danez approved these changes

Assignees
No one assigned
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
v7.4.2
Development

Successfully merging this pull request may close these issues.

Incorrect parser errors about undefined exports in Babel 7.4
4 participants
@nicolo-ribaudo @babel-bot @existentialism @danez