Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flow types in traverse/path/family and enable flow #9870

Merged
merged 1 commit into from Apr 23, 2019

Conversation

@danez
Copy link
Member

commented Apr 18, 2019

Q                       A
Fixed Issues?
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT
@babel-bot

This comment has been minimized.

Copy link
Collaborator

commented Apr 18, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10700/

@@ -203,9 +210,12 @@ export function getBindingIdentifierPaths(
}
}

// $FlowIssue Object.create() is object type

This comment has been minimized.

Copy link
@nicolo-ribaudo

nicolo-ribaudo Apr 18, 2019

Member

Doesn't using const id: { [string]: NodePath } = Object.create(null); above work?

This comment has been minimized.

Copy link
@danez

danez Apr 18, 2019

Author Member

No flow says that the result of Object.create() is not compatible to object type. facebook/flow#4967

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.