Add fix for other types of nodes in referencePaths #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
boopathi
commented
Aug 29, 2016
boopathi
commented
- (Close Unexpected UnaryExpression. Expected an Identifier #122)
- (Close ModuleBuildError: Module build failed: TypeError: Cannot read property 'scope' of undefined #105)
| @@ -873,4 +873,34 @@ describe("mangle-names", () => { | |||
| `); | |||
| expect(transform(source)).toBe(expected); | |||
| }); | |||
|
|
|||
| it("should handle export declarations", () => { | |||
There was a problem hiding this comment.
should add this to DCE as well... or shall I add it to preset tests ?
|
regarding #122 , strangely it happens only for function foo () {
var a;
if (a) {} else {
b()
}
}and not for function foo () {
if (a) {} else {
b()
}
}this is replaced to function foo () {
var a;
if (!a) {
b()
}
}and the referencePath of |
| const babel = require("babel-core"); | ||
| const unpad = require("../../../utils/unpad"); | ||
|
|
||
| function transform(code, options = {}, sourceType = "script") { |
There was a problem hiding this comment.
Maybe it would make sense to move transform to utils and share among tests to avoid duplication?
There was a problem hiding this comment.
Yeah.. Like discussed here #76 ... separate PR for all these things ...
There was a problem hiding this comment.
Oh right, I forgot :) If you can make a PR for that, I'd gladly merge — would make tests a bit cleaner.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.