Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work well with independent mode #26

Open
hzoo opened this issue Aug 31, 2016 · 9 comments
Open

Doesn't work well with independent mode #26

hzoo opened this issue Aug 31, 2016 · 9 comments

Comments

@hzoo
Copy link
Contributor

hzoo commented Aug 31, 2016

Example below

Since each thing is independent it doesn't make sense to have a changelog entry per release since each one is seperate.


Changelog for 2016-08-31

Bug Fix

  • babel-preset-babili
    • #135 update older packages. (@hzoo)
    • #125 Revert "Throw upgrade error when babel version is less than 6.14.0". (@kangax)
    • #116 Throw upgrade error when babel version is less than 6.14.0. (@boopathi)
  • babili
  • babel-plugin-minify-mangle-names, babel-preset-babili
    • #123 Add fix for other types of nodes in referencePaths. (@boopathi)
  • babel-plugin-minify-simplify
    • #119 Fix bug - Conditionals transformation for impure paths. (@boopathi)
@Turbo87
Copy link
Contributor

Turbo87 commented Mar 3, 2017

@hzoo should independent mode generate changelogs per project instead of a global one?

@hzoo
Copy link
Contributor Author

hzoo commented Mar 3, 2017

I'm not sure anymore lol

@fahad19
Copy link

fahad19 commented Mar 5, 2017

I feel it makes sense to generate changelogs per project (in independent mode).

@evocateur
Copy link
Member

lerna publish --conventional-commits supports per-project changelogs in --independent mode, though admittedly not from lerna-changelog directly.

@sthzg
Copy link

sthzg commented Oct 3, 2018

@evocateur I also noticed that the --conventional-commits flag seems to work properly in independent mode.

though admittedly not from lerna-changelog directly

Not sure how to interpret this - was it meant as a hint to look into the code there and potentially reuse some of its logic to gather the relevant info or did you have some specific solution based on that in mind?

Update lerna version --conventional-commits seems to achieve the separate changelogs in 3.x, which obsoletes my question.

@zero-t4
Copy link

zero-t4 commented Jan 13, 2020

lerna publish --conventional-commits supports per-project changelogs in --independent mode, though admittedly not from lerna-changelog directly.

Why doesn't this flag mentioned in docs?

@kylemh
Copy link

kylemh commented Apr 7, 2020

I'd love to integrate some sort of fix for independent mode. I quite like the idea of label-driven changelogs vs. a commit message standard.

Where would this change need to be made?

I can clearly see where I can help infer the package names, but once I have them, I'm not sure how to run the changelog generator against each package. A backward compatible change would be to change repo to packages as an array of strings. A non-independent monorepo would simply be an array of one item.

Do we still want one root-level CHANGELOG.md or should it be per package?

If it's root-level, should there be any new formatting?

@kylemh
Copy link

kylemh commented Apr 20, 2020

@Turbo87 any comments on the above? Really interested in getting this working. I want the PR labels stuff so bad - think it's so much better than relying on commit linting.

@Turbo87
Copy link
Contributor

Turbo87 commented Apr 21, 2020

unfortunately I don't use lerna or yarn workspaces so it's hard for me to comment on this 🙁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants