Init Lerna #6
Init Lerna #6
Conversation
| minified: true, | ||
| comments: false, | ||
| }); | ||
| }; |
There was a problem hiding this comment.
I wasn't sure what to do with this file. Should we have both babel-minify-cli and babel-minify-core like we do with Babel?
There was a problem hiding this comment.
Yeah if we want to be able to use it standalone as well as just a preset then we should do something like that?
There was a problem hiding this comment.
Yeah it's necessary to have all three ways of using it:
- programmatic api
- preset
- cli
|
I'll merge this and then we can work on the cli and api separately |
| plugins: [ | ||
| require('babel-plugin-minify-constant-folding'), | ||
| require('babel-plugin-minify-dead-code-elimination'), | ||
| require('babel-plugin-minify-empty-function'), |
There was a problem hiding this comment.
We don't want to include empty function or replace right? If we do we need to pass in some options + generalize empty-function?
Ref babel/babel#3331
There was a problem hiding this comment.
yeah we don't need it, it's Facebook-specific
There was a problem hiding this comment.
We want to still keep it in the repo though right?
No description provided.