Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: alpha state? #109

Closed
kirrg001 opened this issue Mar 3, 2017 · 7 comments
Closed

Question: alpha state? #109

kirrg001 opened this issue Mar 3, 2017 · 7 comments

Comments

@kirrg001
Copy link

kirrg001 commented Mar 3, 2017

Hey 👋

The last alpha was released on the 5th of Jan.
I am waiting for an update of babel core, because of a vulnerability.
Could you give me an update please?

Thanks 🙂
Kate

@Turbo87
Copy link
Contributor

Turbo87 commented Mar 3, 2017

what "vulnerability" is that?

@kirrg001
Copy link
Author

kirrg001 commented Mar 3, 2017

minimatch@2.0.10

(+) 1 vulnerabilities found
┌───────────────┬───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┐
│               │ Regular Expression Denial of Service                                                                                                                                              │
├───────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Name          │ minimatch                                                                                                                                                                         │
├───────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Installed     │ 2.0.10                                                                                                                                                                            │
├───────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Vulnerable    │ <=3.0.1                                                                                                                                                                           │
├───────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Patched       │ >=3.0.2                                                                                                                                                                           │
├───────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ Path          │ ghost@1.0.0-alpha.14 > ghost-editor@0.1.10 > ember-cli-babel@5.2.4 > broccoli-babel-transpiler@5.6.2 > babel-core@5.8.38 > minimatch@2.0.10                                       │
├───────────────┼───────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────┤
│ More Info     │ https://nodesecurity.io/advisories/118                                                                                                                                            │
└───────────────┴──────────────────────────────────────────

@Turbo87
Copy link
Contributor

Turbo87 commented Mar 3, 2017

are you passing user input into minimatch?

@kirrg001
Copy link
Author

kirrg001 commented Mar 6, 2017

I think we are not using it right now, but maybe other people do.

@Turbo87
Copy link
Contributor

Turbo87 commented Mar 6, 2017

to be honest I don't see how anyone could actually take advantage of that vulnerability through the broccoli-babel-transpiler plugin. broccoli is usually used in the build pipeline where usually no user input is part of the build or could be harmful in any way. as there is no user input there is also no realistic way to take advantage of such a vulnerability. unless you can demonstrate that this is an actual issue I'd like to close this issue.

as for Babel 6: we (mainly @rwjblue) are actively working on supporting Babel 6 in Ember CLI (and Broccoli) in the near future, but we are not done yet.

@kirrg001
Copy link
Author

kirrg001 commented Mar 6, 2017

Ok 👍 Is there any deadline planned for your upcoming release?

@Turbo87
Copy link
Contributor

Turbo87 commented Mar 6, 2017

we are hoping to get an MVP in Ember CLI 2.13, but as we're talking about an OSS project there are no guarantees at all

@Turbo87 Turbo87 closed this as completed Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants