cleanup #7
Merged
cleanup #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stefanpenner
commented
Jan 5, 2015
stefanpenner
commented
- proper test setup (no more delegating to a cli)
- test for configuration (inline vs non-inline source map)
- update links package.json
* test for configuration (inline vs non-inline source map) * update links package.json
stefanpenner
changed the title
* remove now defunct comment (we just do inline source maps)
| throw err; | ||
| } | ||
| TranspilerFilter.prototype.copyOptions = function() { | ||
| return JSON.parse(JSON.stringify(this.options)); |
There was a problem hiding this comment.
You could just add https://www.npmjs.com/package/lodash.clonedeep.
There was a problem hiding this comment.
I think this is fine for now, once the future lands we can do that.
If you are extremely set on pulling in clondeep for this, I will gladly doit.
|
@sebmck anything i can do to move this along? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.