Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and babel (6) #70

Merged
merged 4 commits into from
Jun 4, 2016

Conversation

topaxi
Copy link
Contributor

@topaxi topaxi commented Dec 21, 2015

Updates all dependencies and babel to 6

@topaxi
Copy link
Contributor Author

topaxi commented Dec 21, 2015

This PR depends on stefanpenner/hash-for-dep#22 being fixed.

@topaxi
Copy link
Contributor Author

topaxi commented Dec 21, 2015

I just noticed, that this module tries to include the browser polyfill if options.browserPolyfill is truthy.
Shall I include this functionality via the babel-polyfill module or should I remove it completely?

With the modular design of Babel 6, I'm not sure if this should still be handled in this module anymore.
It should be trivial to include the babel-polyfill in any broccoli build anyways.

@maherbeg
Copy link

@topaxi I'd make it an option to pass through as long the version is updated! Thanks for taking this on, I was just about to do it.

@maherbeg
Copy link

Fixes #62

@shaunc
Copy link

shaunc commented Feb 4, 2016

@topaxi -- I obviously should have checked for your work before I tried to role my own (#73). The failure seen should go through. I think you need to fix the "named module" and "moduleID - true" tests by including plugins: ["transform-es2015-modules-amd"] rather than the modules option. (see this commit)... I'll close out mine if you are still pushing this.

@topaxi
Copy link
Contributor Author

topaxi commented Feb 4, 2016

@shaunc I'm not sure what you mean, I'm not using the modules option anymore?

@topaxi
Copy link
Contributor Author

topaxi commented Feb 4, 2016

The build seems to be failing for windows, maybe Babel 6 supports windows newlines and #58 can be reverted?
I have no windows machine to test this so I'm hesitating on changing and pushing this randomly.

@topaxi topaxi changed the title Update dependencies and babel Update dependencies and babel (6) Feb 4, 2016
@Turbo87
Copy link
Contributor

Turbo87 commented Apr 6, 2016

@topaxi can you rebase on master?

@topaxi
Copy link
Contributor Author

topaxi commented Apr 6, 2016

Rebased and green! 🎉

@Turbo87
Copy link
Contributor

Turbo87 commented Apr 6, 2016

awesome!

@stefanpenner can you have a look at this once you're done in Switzerland?

@Turbo87 Turbo87 mentioned this pull request Apr 6, 2016
@amercier
Copy link

amercier commented May 6, 2016

@topaxi Tried this on one of my project, and this it seems to be working as expected. Good work! Looking forward for this to be merged!

@topaxi topaxi mentioned this pull request May 16, 2016
@maherbeg
Copy link

maherbeg commented Jun 3, 2016

@Turbo87 Anything we can do to get this merged in?

@Turbo87 Turbo87 mentioned this pull request Jun 4, 2016
@Turbo87
Copy link
Contributor

Turbo87 commented Jun 4, 2016

Okay, so the way forward from my perspective would be:

  • create a 5.x branch for bugfixes on the old version
  • merge this PR into master
  • release 6.0.0-alpha.1
  • see how ember-cli-babel handles the new version

@stefanpenner any objections?

@shaunc
Copy link

shaunc commented Jun 4, 2016

+1 :)

@stefanpenner
Copy link
Member

@stefanpenner any objections?

sounds perfect

@Turbo87 Turbo87 merged commit 17b304d into babel:master Jun 4, 2016
@Turbo87 Turbo87 mentioned this pull request Jun 4, 2016
Closed
@Turbo87
Copy link
Contributor

Turbo87 commented Jun 4, 2016

@topaxi it seems like master has a failing test now after merging this. could you have a look at what might be causing this?

@Turbo87
Copy link
Contributor

Turbo87 commented Jun 8, 2016

@stefanpenner could you add me to https://www.npmjs.com/package/broccoli-babel-transpiler/ so that I can release 6.0.0-alpha.1?

@stefanpenner
Copy link
Member

stefanpenner commented Jun 8, 2016

➜  ~ npm owner add turbo87  broccoli-babel-transpiler
+ turbo87 (broccoli-babel-transpiler)

@Turbo87
Copy link
Contributor

Turbo87 commented Jun 9, 2016

v6.0.0-alpha.1 released! 🎉

@Turbo87 Turbo87 mentioned this pull request Jun 24, 2016
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants