-
-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and babel (6) #70
Conversation
This PR depends on stefanpenner/hash-for-dep#22 being fixed. |
I just noticed, that this module tries to include the browser polyfill if With the modular design of Babel 6, I'm not sure if this should still be handled in this module anymore. |
@topaxi I'd make it an option to pass through as long the version is updated! Thanks for taking this on, I was just about to do it. |
Fixes #62 |
@topaxi -- I obviously should have checked for your work before I tried to role my own (#73). The failure seen should go through. I think you need to fix the "named module" and "moduleID - true" tests by including |
@shaunc I'm not sure what you mean, I'm not using the |
The build seems to be failing for windows, maybe Babel 6 supports windows newlines and #58 can be reverted? |
@topaxi can you rebase on |
ef13f84
to
9a0ad1c
Compare
Rebased and green! 🎉 |
awesome! @stefanpenner can you have a look at this once you're done in Switzerland? |
@topaxi Tried this on one of my project, and this it seems to be working as expected. Good work! Looking forward for this to be merged! |
@Turbo87 Anything we can do to get this merged in? |
Okay, so the way forward from my perspective would be:
@stefanpenner any objections? |
+1 :) |
sounds perfect |
@topaxi it seems like master has a failing test now after merging this. could you have a look at what might be causing this? |
@stefanpenner could you add me to https://www.npmjs.com/package/broccoli-babel-transpiler/ so that I can release 6.0.0-alpha.1? |
|
v6.0.0-alpha.1 released! 🎉 |
Updates all dependencies and babel to 6