Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useBuiltIns not working #166

Open
simonihmig opened this issue Jul 12, 2017 · 2 comments
Open

useBuiltIns not working #166

simonihmig opened this issue Jul 12, 2017 · 2 comments

Comments

@simonihmig
Copy link
Contributor

Is useBuiltIns supposed to work here?

I guess no, because the polyfill is imported using ember-cli, so there is no import "babel-polyfill"; statement that this babel plugin is looking for, if I correctly understand that. Reducing the needed polyfill parts is probably tackled by #142, not using the useBuiltIns option, right?

If that is the case, this option should probably removed from the Readme, or mention that this is not working!?

@houfeng0923
Copy link

useBuiltIns still can't work in 2020

@nickschot
Copy link

Still seems to be a problem with ember-cli-babel 8 (embroider safe) w/ core-js 3. Attempting to use useBuiltIns: 'usage' will add the imports, but gives a runtime error that the core-js files can't be found.

Trying to look into it a bit further...

I think useBuiltIns: 'entry' is basically a no-op at the moment? It seems to keep the core-js/stable (or whatever) import in-place which will import all the polyfills, meaning it's not run properly.

When I use core-js-builder with our browser targets I get a significantly smaller set of polyfills. I guess using that wrapped in a webpack plugin or whatever could be a temporary alternative to useBuiltIns: 'entry'.

'usage' would however probably be the more ideal solution...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants