Switch curly and no-case-declarations to errors #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hzoo
approved these changes
Mar 3, 2017
|
btw we have 3 other rules on in master, should get in as many as possible before next release |
|
Nice. Personally, my vote would be to add these to https://github.com/babel/babel/blob/7.0/.eslintrc in a PR alongside the style fixes, then once we're happy, make a PR to this repo. It seems like a pain to slowly accumulate these over here one at a time. |
|
Great idea Logan |
existentialism
force-pushed
the
existentialism-patch-1
branch
from
d4fb46d
to
3210ef8
Compare
|
Guess it's time to update this :) We've been running |
existentialism
changed the title
nicolo-ribaudo
pushed a commit
to babel/babel
that referenced
this pull request
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
babel/babel#5412 (comment)