Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests do not fail when there are global leaks when in node env #196

Closed
jamesplease opened this issue Aug 2, 2015 · 1 comment
Closed

Tests do not fail when there are global leaks when in node env #196

jamesplease opened this issue Aug 2, 2015 · 1 comment
Labels
bug

Comments

@jamesplease
Copy link
Member

Atm the tests ignore globals leaks when run in a node env (like when gulp test is run). Passing ignoreLeaks: false fixes this, but it causes another error: the stream seems to exit without throwing an error, so there's no indication to the user what has happened.
@jamesplease jamesplease added the bug label Aug 2, 2015
@jamesplease jamesplease changed the title Fail when there are leaks in node env Does not fail when there are leaks in node env Aug 9, 2015
@jamesplease jamesplease changed the title Does not fail when there are leaks in node env Tests do not fail when there are global leaks when in node env Aug 9, 2015
jamesplease added a commit that referenced this issue Oct 9, 2015
@jamesplease
Ensure tests fail when there are leaks.
9bab337 
Resolves #196
@jamesplease jamesplease mentioned this issue Oct 9, 2015
Merged
@jamesplease
Copy link
Member Author

Done!

jamesplease added a commit that referenced this issue Dec 30, 2015
@jamesplease
Ensure tests fail when there are leaks.
d2f4ae3 
Resolves #196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jamesplease