Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify copying of files #199

Closed
jamesplease opened this issue Aug 4, 2015 · 4 comments
Closed

Simplify copying of files #199

jamesplease opened this issue Aug 4, 2015 · 4 comments
Labels
Milestone

Comments

@jamesplease
Copy link
Member

#197 (comment)

This greatly simplifies the file copying logic, but it breaks from the Yeoman naming conventions. Is that worth it? Probably, but I'm going to think about it for awhile.

@jamesplease
Copy link
Member Author

If I had to guess, the Yeoman naming conventions are there because package.json is a special file, but _package.json is not. I'm not sure how important it is to separate that out, though...it's not like anyone is going to go into their global npm install directory and run an npm command in this directory.

@thejameskyle / @megawac what do you think?

@megawac
Copy link
Contributor

megawac commented Oct 9, 2015

Yeah, I think its a non issue to consider

@jamesplease
Copy link
Member Author

Yeah I'll prob. update to use the simpler code

@jamesplease jamesplease added this to the v6.0.0 milestone Oct 10, 2015
jamesplease added a commit that referenced this issue Oct 10, 2015
@jamesplease
Copy link
Member Author

Done

jamesplease added a commit that referenced this issue Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants