Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coverage broken on master #238

Closed
jamesplease opened this issue Oct 9, 2015 · 6 comments
Closed

Coverage broken on master #238

jamesplease opened this issue Oct 9, 2015 · 6 comments
Labels
Milestone

Comments

@jamesplease
Copy link
Member

Might be releated to the string of commits here: 62cbe18, but I'm not sure. Investigation underway!

@jamesplease jamesplease added the bug label Oct 9, 2015
@jamesplease jamesplease added this to the v6.0.0 milestone Oct 10, 2015
@jamesplease
Copy link
Member Author

This worked on a recent commit before the switch to Yeoman, e49f661. I'm still investigating the cause...

The isparta and istanbul deps are identical. I copy + pasted the new module and new test to the old code, and it still worked. I then copy+pasted the old task to the new Gulpfile, and it was still broken. Really confused about this one!

Same Babel dep, too.

@jamesplease
Copy link
Member Author

This is caused by overriding Istanbul's require wrap. The order needs to go Babel => Istanbul, but the refactor in 62cbe18 inadvertently made it go Babel => Istanbul => Babel.

@jamesplease
Copy link
Member Author

I'll likely need to make a PR to fix this on Parsley as well.

//cc @marcandre

: P

Oops, my mistake. This bug was never released. Carry on!

@jamesplease
Copy link
Member Author

Copy+pasting the old Gulpfile into the new fixes the problem, so it's def. something in the Gulpfile

@jamesplease
Copy link
Member Author

The issue is described in this issue: douglasduteil/isparta#45

Solution is here: douglasduteil/isparta#45 (comment)

@jamesplease
Copy link
Member Author

Done!

jamesplease added a commit that referenced this issue Dec 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant