benchmark npm packages directly #165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! |
hzoo
reviewed
Sep 22, 2016
| @@ -12,14 +12,28 @@ const babel = require("babel-core"); | |||
| const zlib = require("zlib"); | |||
| const fs = require("fs"); | |||
| const path = require("path"); | |||
| const Command = require("commander").Command; | |||
There was a problem hiding this comment.
I don't think we are using commander?
There was a problem hiding this comment.
Sorry, I didn't realize commander was pulled in by another package. Have added commander to devDependencies in package.json
|
@garyjN7 could you please rebase |
|
we can merge it manually |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
benchmark.js has been changed to allow the installation of node packages and run benchmark tests against files in the package. This will allow the benchmark tests to be easily ran against a wider range of projects.