Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix guarded expressions #179

Merged
merged 1 commit into from
Oct 5, 2016
Merged

Fix guarded expressions #179

merged 1 commit into from
Oct 5, 2016

Conversation

boopathi
Copy link
Member

@boopathi boopathi commented Oct 5, 2016

@kangax kangax merged commit 11664eb into master Oct 5, 2016
boopathi
boopathi commented Oct 5, 2016
View reviewed changes
packages/babel-plugin-minify-guarded-expressions/src/index.js
// the rightside of the expression;
// if the left side is evaluated to be deterministic,
// we can safely replace the entire expression
const shouldBail = !path.parentPath.isExpressionStatement();
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope this assumption doesn't have any corner cases that fail. Will add test cases once this seems to work out well for all corner cases.

@kangax
Copy link
Member

kangax commented Oct 5, 2016

Looks reasonable, thanks!

@kangax kangax deleted the fix-guards-0 branch October 5, 2016 19:16
@ahutchings ahutchings mentioned this pull request Oct 7, 2016
Closed
@snyk-bot snyk-bot mentioned this pull request Mar 17, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@boopathi @kangax