Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse removed vars in mangler #284

Closed
wants to merge 5 commits into from
Closed

Reuse removed vars in mangler #284

wants to merge 5 commits into from

Conversation

boopathi
Copy link
Member

@boopathi boopathi commented Nov 19, 2016

Adds a new mangler option - reuse when set to true reuses vars which are removed and not yet used in the current scope.

Test suite:

Now this contains two test suites with identical tests - one uses default option, and the other uses reuse=true.

perf fixes:

  • use reuse option in calculating resetnext
  • TopLevel option
  • don't traverse scope.crawl when not reusing
  • don't collect Refs and Bindings when reuse is false

@vigneshshanmugam
Copy link
Member

@boopathi This is done for better gzip compression?

@boopathi
Copy link
Member Author

@vigneshshanmugam
Copy link
Member

@boopathi cool got it 👍

@boopathi boopathi added Tag: New Feature Pull Request adding a new feature Tag: Polish Pull Request for formatting, style changes, code cleanups, comments etc... and removed enhancement Tag: Polish Pull Request for formatting, style changes, code cleanups, comments etc... labels Nov 20, 2016
@boopathi
Copy link
Member Author

boopathi commented Nov 21, 2016

Upstream changes - babel/babel#4876

@boopathi boopathi mentioned this pull request Jan 31, 2017
8 tasks
@boopathi boopathi closed this Apr 18, 2017
@boopathi boopathi deleted the reuse-vars-1 branch April 18, 2017 15:46
@boopathi boopathi moved this from Mangler PRs to Done in Mangler May 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tag: New Feature Pull Request adding a new feature
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants