Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't try and minify props that contain unicode #416

Closed
wants to merge 1 commit into from
Closed

don't try and minify props that contain unicode #416

wants to merge 1 commit into from

Commits on Feb 12, 2017

  1. don't minify invalid unicode object property names 

    Firefox 50.1.0 (one behind latest stable) and Safari 10.0.2 (latest stable)
are unable to parse object literal properties that contain unicode characters
which are not valid ES5 identifiers.

The minifier saves bytes by converting objects such as { '\u2118':'wp' } into
{℘:'wp'}, which only works when the key is a valid identifier.

The fix involves bypassing any properties with string representation
containing characters outside of the a-zA-Z0-9_$ range.
    danprince committed Feb 12, 2017
    Configuration menu
    Copy the full SHA
    4441f45 View commit details
    Browse the repository at this point in the history