Clarify typescript preset/plugin scope #2399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for babel ready! Built with commit 4ad7b23 |
|
Note that I wouldn't be opposed to it being |
nicolo-ribaudo
approved these changes
Feb 1, 2021
docs/preset-typescript.md
Outdated
| @@ -34,10 +34,15 @@ npm install --save-dev @babel/preset-typescript | |||
|
|
|||
| ### With a configuration file (Recommended) | |||
|
|
|||
| Note that although TypeScript compiler `tsc` actively supports new JavaScript proposals such as optional chaining (`?.`), nullish coalescing (`??`) and class properties (`this.#x`), this preset does not include these features because they are not | |||
| the types syntax available in TypeScript only. We recommend using `preset-env` with `preset-typescript` if you want to transpile these features. | |||
There was a problem hiding this comment.
The following might be confusing:
this preset does not include these features because they are not the types syntax available in TypeScript only
Maybe something like:
this preset does not include these features as it is currently only meant to support the TypeScript types syntax.
Thoughts?
There was a problem hiding this comment.
The latter definitely looks better.
Co-authored-by: Brian Ng <bng412@gmail.com>
JLHwung
force-pushed
the
clarify-typescript-preset-scope
branch
from
e0a0e82
to
4ad7b23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constantly we have feature requests like babel/babel#10690 babel/babel#12030 to include staged 3 features that are supported in TypeScript compilers. Since we are not making
preset-typescriptapreset-whatever-tsc-can-do, we should clarify this point on the docs.Resolves babel/babel#12030
Fixes #2311