Add babel-preset-env 2.0 support. Controll version/build from the circle. #1415

yavorsky · 2017-10-10T10:37:49Z

Since we've moved babel-preset-env to the original repo and going to move babel-preset-env-standalone, we can take the same advantage like we're used with babel-standalone.

This PR:

Add envVersion query param for babel-preset-env version, so /#?envVersion=2.0.0-beta.2 will use it for the repl.
Allows testing preset-env changes after each PR by using build version to get artifacts from the Circle CI along with babel-standalone.
Displays current version near the preset:
Fixes env preset checkbox state when initializing. Change text color inside textarea.
Add the most features from the latest preset-env:
- useBuiltIns: usage/entry
- forceAllTransforms
All preset options are links to the documentation:

🚧 I've disabled debug option unless onPresetBuild support will be merged. I'll move PR to the monorepo today.

The next steps:

Enable debug
Add stage-3 option (babel-plugin-transform-async-generator-functions is large, so we need to lazy load it and register, but before we registered preset-env :/).
Since preset-env is 160kb, maybe load it right off the bat ?

babel-bot · 2017-10-10T10:39:20Z

Deploy preview for babel ready!

Built with commit 1b935a1

https://deploy-preview-1415--babel.netlify.com

yavorsky · 2017-10-10T11:42:55Z

Seems like netlify preview breaks down with new commits after the first successful build.

existentialism · 2017-10-10T14:11:20Z

Let's set these dropdowns to normal font-weight:

existentialism · 2017-10-10T14:11:51Z

js/repl/PluginConfig.js

 const envPresetConfig: PluginConfig = {
  label: "Env Preset",
  package: "babel-preset-env-standalone",
-  version: "0",
+  version: "2.0.0-beta.2",


Should we default this to 1.x since we default to Babel 6.x?

yavorsky · 2017-10-13T10:05:45Z

@existentialism Updated:
Now, babel-preset-env 1.6 is by default.
Also, we have different options according to the version:

For ^2.0:

For older versions:

yavorsky · 2017-11-14T17:02:02Z

Changed status to WIP, because we need to land babel/babel#6438 firstly and then fit it there.

# Conflicts: # js/repl/Repl.js # js/repl/ReplOptions.js # js/repl/Worker.js # js/repl/WorkerApi.js # js/repl/loadBabel.js # js/repl/types.js

yavorsky · 2017-11-17T12:22:05Z

Seems like it's ready.

It works with babel-preset-env 2.0 betas and with circleci builds. So after each PR into experimental/babel-preset-env we could test preset's changes on the REPL also!
Tested with babel/babel#6438 (5831 build).

The only thing is that I need to test @babel/preset-env-standalone fetching when it will be npm published.

cc @hzoo @existentialism

hzoo · 2017-11-17T13:10:26Z

js/repl/loadBundle.js

    (semver.valid(version) && semver.gte(version, "7.0.0-beta.4")) ||
    version >= 7
-      ? "@babel/standalone"


my thoughts: I kinda feel like it's easier to read/maintain with hardcoding this stuff? If we rename or anything like that I'm not sure I'd know where to look in this codebase with so much indirection? And in this case we can't substitute babel-standalone env in the same way because it won't be published until beta.33 not beta.4

xtuc · 2017-12-25T12:13:46Z

Does bundle.run support externals yet?

We actually discussed about that a few months ago (Rich-Harris/packd#27) but I forgot about it.

Your point is still valid, I agree. I will work on it when I get a chance.

# Conflicts: # _data/users.yml # js/repl/CircleCI.js # js/repl/PluginConfig.js # js/repl/Repl.js # js/repl/ReplOptions.js # js/repl/compile.js # js/repl/replUtils.js # js/repl/types.js

yavorsky · 2018-01-05T13:33:03Z

I hope this is finished 🙄

Would be cool if someone will help to test it better

After, I could start work on the includes/excludes and size prediction bar.

xtuc · 2018-01-10T13:09:44Z

Sorry I haven't followed this PR so much, what is the status of babel-standalone having the incorrect version of Babel?

yavorsky · 2018-01-10T13:39:47Z

@xtuc We can fix only publishing process, but it won't fully solve the problem because all versions published before this fix to npm will still return the previous version.

I've created PR for the website, which disables version overriding: #1488
There are some questions need to be resolved before we can merge this. For example, should we override non-semver values like (7). Currently, it prevent's overriding only semver values, but won't override master, 7, 6117 (build number).

yavorsky · 2018-01-10T13:41:35Z

This PR isn't blocked by this bug because it's already present on the https://babeljs.io

existentialism · 2018-01-10T14:53:29Z

js/repl/PluginConfig.js

+
+const stage3Plugins: Array<PluginConfig> = [
+  "proposal-async-generator-functions",
+  // "proposal-object-rest-spread",


oops, I probably confused you, but I meant to say that we should add a comment describing why we need stage3Plugins (i.e. proposal-async-generator-functions not available >= beta.36)

existentialism · 2018-01-10T14:54:13Z

js/repl/PluginConfig.js

@@ -58,20 +112,26 @@ const replDefaults: ReplState = {
  isPresetsTabExpanded: false,
  isSettingsTabExpanded: true,
  lineWrap: true,
+  presets: "es2015,react,stage-2",


Nit: why was this moved? I kinda prefer this being alpha sorted :) (no big deal)

Oh, I just merged crookedly. Will fix, thanks :)

existentialism · 2018-01-10T14:55:40Z

js/repl/Repl.js

      code: persistedState.code,
      compiled: null,
      compileErrorMessage: null,
      debugEnvPreset: persistedState.debug,
      envConfig,
      envPresetDebugInfo: null,
-      envPresetState: configToState(
+      envPresetState: persistedStateToEnvState(


Not a blocker, but we should step back and re-think/clean up the state shape now that we have all a number of things that may or may not be loaded and depending on version, etc

existentialism · 2018-01-10T14:56:30Z

js/repl/ReplOptions.js

+  <a
+    className={className}
+    target="_blank"
+    href={`https://github.com/babel/babel/tree/master/experimental/babel-preset-env#${section}`}


This link needs updating

existentialism · 2018-01-10T14:59:24Z

js/repl/ReplOptions.js

+    this.props.onEnvPresetSettingChange("electron", event.target.value);
+  };
+
+  _onShippedProposalsChange = (event: SyntheticInputEvent) => {


Nit: we could replace these with something more generic for the checkboxes:

_onEnvSettingChange = (event: SyntheticInputEvent) => { this.props.onEnvPresetSettingChange(event.target.name, event.target.checked) }

existentialism · 2018-01-10T15:01:15Z

js/repl/loadBundle.js

+import { BabelState } from "./types";
+import WorkerApi from "./WorkerApi";
+
+const SCOPED_CORE_VERSION_FROM = "7.0.0-beta.4";


The things we do to ourselves :)

aha exactly!

yavorsky · 2018-01-20T17:24:05Z

@existentialism Thanks for the review! 🎉

yavorsky added 9 commits October 9, 2017 22:44

Add preset-env 2.0 builtIns options.

c96f982

Use updated babel-preset-env-standalone.

e3f2862

Fix enabled state for env preset.

834594b

Refactor to allow using version/build for preset-env.

4004f78

Remove old babel module.

222a51e

Show version for babel-preset-env.

6f04b74

Add forceAllTransforms option.

5ae7dce

Navigate to docs section when clicking on option

10130a7

Disable debug for preset-env.

35bf46c

Remove fromMonorepo deprecated option.

33dd97d

yavorsky closed this Oct 10, 2017

yavorsky reopened this Oct 10, 2017

Version is optional

737198f

existentialism reviewed Oct 10, 2017

View reviewed changes

yavorsky added 2 commits October 12, 2017 15:00

Normal font weight for select/number inputs.

446c5d3

Flexible env options according to the version.

a474396

yavorsky changed the title ~~Add babel-preset-env 2.0 support. Controll version/build from the circle.~~ [WIP] Add babel-preset-env 2.0 support. Controll version/build from the circle. Nov 14, 2017

yavorsky added 3 commits November 17, 2017 02:36

Consider that babel-preset-env latest is 7.

d8b43be

Merge brunch master into preset-env-2.0-features

d01c894

Merge branch 'master' into preset-env-2.0-features

6f8c194

# Conflicts: # js/repl/Repl.js # js/repl/ReplOptions.js # js/repl/Worker.js # js/repl/WorkerApi.js # js/repl/loadBabel.js # js/repl/types.js

hzoo reviewed Nov 17, 2017

View reviewed changes

yavorsky added 3 commits November 17, 2017 15:24

Oops

44063a2

Override gap for unregistered preset-env versions

e8c08f3

Fetch and register shipped proposals in bundles.

ed07d14

yavorsky added 3 commits December 25, 2017 11:47

Rename convertPluginNameToInsanceName to normalizePluginName.

c65e590

Update isLoaded state

595deaa

Merge branch master into 2.0.

fe110f1

yavorsky mentioned this pull request Dec 28, 2017

include/exclude preset-env option for the REPL #1497

Closed

Merge branch 'master' into 2.0

0ded68e

# Conflicts: # _data/users.yml # js/repl/CircleCI.js # js/repl/PluginConfig.js # js/repl/Repl.js # js/repl/ReplOptions.js # js/repl/compile.js # js/repl/replUtils.js # js/repl/types.js

yavorsky changed the title ~~[WIP] Add babel-preset-env 2.0 support. Controll version/build from the circle.~~ Add babel-preset-env 2.0 support. Controll version/build from the circle. Jan 5, 2018

yavorsky added 2 commits January 5, 2018 15:59

Don’t compile if env preset enabled, but not loaded yet.

f6b50d5

Disable already registered stage 3 plugins.

306b250

yavorsky requested review from existentialism, hzoo and xtuc January 10, 2018 11:24

existentialism reviewed Jan 10, 2018

View reviewed changes

Override preset-env version to 7 if babel is 7.

26c5136

yavorsky requested a review from existentialism January 12, 2018 00:23

yavorsky added 5 commits January 12, 2018 02:27

Fix preset-env url to docs

4481f73

Default plugins are alpha sorted.

9ccf2fa

Unify methods for checkbox/input updates.

e99a269

Add description for stage-3 plugins config.

1902cf1

Bump default electron/node versions

1b935a1

existentialism approved these changes Jan 16, 2018

View reviewed changes

existentialism merged commit 61e6378 into master Jan 20, 2018

yavorsky deleted the preset-env-2.0-features branch January 20, 2018 17:25

existentialism mentioned this pull request Jan 20, 2018

REPL: default to preset-env that matches babel version #1516

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add babel-preset-env 2.0 support. Controll version/build from the circle. #1415

Add babel-preset-env 2.0 support. Controll version/build from the circle. #1415

yavorsky commented Oct 10, 2017 •

edited

babel-bot commented Oct 10, 2017 •

edited

yavorsky commented Oct 10, 2017

existentialism commented Oct 10, 2017

existentialism Oct 10, 2017

yavorsky commented Oct 13, 2017 •

edited

yavorsky commented Nov 14, 2017

yavorsky commented Nov 17, 2017 •

edited

hzoo Nov 17, 2017

xtuc commented Dec 25, 2017

yavorsky commented Jan 5, 2018 •

edited

xtuc commented Jan 10, 2018

yavorsky commented Jan 10, 2018 •

edited

yavorsky commented Jan 10, 2018 •

edited

existentialism Jan 10, 2018

existentialism Jan 10, 2018

yavorsky Jan 10, 2018

existentialism Jan 10, 2018

existentialism Jan 10, 2018

existentialism Jan 10, 2018

existentialism Jan 10, 2018

xtuc Jan 10, 2018

yavorsky commented Jan 20, 2018

Add babel-preset-env 2.0 support. Controll version/build from the circle. #1415

Add babel-preset-env 2.0 support. Controll version/build from the circle. #1415

Conversation

yavorsky commented Oct 10, 2017 • edited

babel-bot commented Oct 10, 2017 • edited

yavorsky commented Oct 10, 2017

existentialism commented Oct 10, 2017

Choose a reason for hiding this comment

yavorsky commented Oct 13, 2017 • edited

yavorsky commented Nov 14, 2017

yavorsky commented Nov 17, 2017 • edited

Choose a reason for hiding this comment

xtuc commented Dec 25, 2017

yavorsky commented Jan 5, 2018 • edited

xtuc commented Jan 10, 2018

yavorsky commented Jan 10, 2018 • edited

yavorsky commented Jan 10, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yavorsky commented Jan 20, 2018

yavorsky commented Oct 10, 2017 •

edited

babel-bot commented Oct 10, 2017 •

edited

yavorsky commented Oct 13, 2017 •

edited

yavorsky commented Nov 17, 2017 •

edited

yavorsky commented Jan 5, 2018 •

edited

yavorsky commented Jan 10, 2018 •

edited

yavorsky commented Jan 10, 2018 •

edited