Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign REPL add plugin modal #1656

Merged
merged 4 commits into from Jun 5, 2018
Merged

Redesign REPL add plugin modal #1656

merged 4 commits into from Jun 5, 2018

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented May 11, 2018

mm

Another PR extracted from the smooshpack branch.

(Note: adding plugins via search is currently broken on new.babeljs.io)

TODO:

@hzoo
Copy link
Member

hzoo commented May 11, 2018

Deploy preview for babel-new ready!

Built with commit a156a5a

https://deploy-preview-1656--babel-new.netlify.com

@existentialism
Copy link
Member Author

@hzoo should be good to go, going to punt on todo item 2 (filtering), as I couldn't get filtering on name to work right. will just look at it later :)

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow nice! Good job

@xtuc
Copy link
Member

xtuc commented Jun 5, 2018

cc @Haroenv just in case

Copy link
Contributor

@Haroenv Haroenv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good, appreciate it!

The "powered by" is slightly off-center, if you want you can use the svg version: <PoweredBy />

@existentialism
Copy link
Member Author

@Haroenv thanks! I fixed the alignment of "search by", and it's actually already using the <PoweredBy/>!

While I have you, I was trying to filter already added plugins from the search results but couldn't get it to work (tried various combinations of adding AND NOT name:<name>, and using various facet-related things). Any ideas?

@Haroenv
Copy link
Contributor

Haroenv commented Jun 5, 2018

ah that's because name was not an attribute you can facet, but objectID is, can you try AND NOT objectID:<name>. The objectID is the same as the name

@existentialism
Copy link
Member Author

@Haroenv 🙏 💯 thanks!

@Haroenv
Copy link
Contributor

Haroenv commented Jun 5, 2018

did that work as expected @existentialism ?

@existentialism
Copy link
Member Author

@Haroenv yep! just pushed an update, netlify should update in a sec. thanks again!

@existentialism existentialism merged commit d0e77d3 into master Jun 5, 2018
@existentialism existentialism deleted the add-plugin-modal branch June 5, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants