WIP: Fix code-block-buttons.js to work in IE11 #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for babel failed. Built with commit 224a96f https://app.netlify.com/sites/babel/deploys/5b72cc02b312747ef9bc50c4 |
|
@gyujincho just took at look at this in IE11... I think we can avoid transpiling, as the only thing that seems to be breaking is: document.querySelectorAll(codeBlockSelector).forEach(...)We can probably just copy/paste a polyfill (like this one). (Also looks like we need to fix the css for the copy button for IE11) |
Closed
|
Even if we fix this one file, there are more issues in order to get stuff working in IE11. For example docusaurus ships template strings in some files which get directly sent to browser. https://github.com/facebook/Docusaurus/blob/master/packages/docusaurus-1.x/lib/static/js/codetabs.js It is probably not worth fixing imho. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
code-block-buttons.jswith babel and includebabel-polyfillbabel-minify-webpack-pluginWIP because not tested in an actual IE11 browser yet(currently don't have one, will test with Netlify link in a few days)