Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package titles to be scoped #1770

Merged
merged 1 commit into from
Aug 25, 2018
Merged

Conversation

notlmn
Copy link
Contributor

@notlmn notlmn commented Aug 25, 2018

Fixes #1768

Changed all current package titles to be scoped, and fixed some doc issues along the way.

@babel-bot
Copy link
Contributor

Deploy preview for babel ready!

Built with commit 79db698

https://deploy-preview-1770--babel.netlify.com

Copy link
Member

@existentialism existentialism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@existentialism
Copy link
Member

@notlmn thanks!

@existentialism existentialism merged commit b3a9f0b into babel:master Aug 25, 2018
@nicolo-ribaudo
Copy link
Member

We also need to update them in the tooling section in the left sidebar at https://deploy-preview-1770--babel.netlify.com/docs/en/next

@notlmn
Copy link
Contributor Author

notlmn commented Aug 25, 2018

@nicolo-ribaudo Yeah, I also thought of that, but other parts of the docs have babel- prefix, and some don't. I was waiting to ask if the prefix should be removed (in id and in sidebar_label).

I'll submit a PR when I get back home.

@notlmn notlmn deleted the change-titles branch August 25, 2018 14:36
@notlmn
Copy link
Contributor Author

notlmn commented Aug 26, 2018

I've hit a wall while modifying the other fields, which may be a bug with Docusaursus, where it mixes up strings of all versions in the same file, causing the sidebar labels to be messed up (test repo).

I've reached out to the people at Docusaurus, the new PR may take a while.

@notlmn
Copy link
Contributor Author

notlmn commented Aug 26, 2018

@nicolo-ribaudo The sidebar label change cannot be made as of now because of a bug in Docusaurus. I've opened an issue over at the Docusaurus repo.

The change can happen once the issue is resolved, or a workaround is to use different values for id (without the version-XX part) and sidebar_label in these docs to be different.

@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented Aug 26, 2018

Ok, we can wait then. Thank you for investigating!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change the titles for all the packages
4 participants