Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak preset-env docs #2252

Merged
merged 3 commits into from
Aug 5, 2020
Merged

Tweak preset-env docs #2252

merged 3 commits into from
Aug 5, 2020

Conversation

existentialism
Copy link
Member

@existentialism existentialism commented May 16, 2020

Attempts to address:

  • Adds an explicit "No targets" subsection to the targets option

  • Improves description around preset-env's current behavior wrt to browserslist defaults query

  • Remove and tweak the description of the debug option (didn't really read well)

  • Fix a broken link in v7.0.0 docs

  • Removed an extraneous [Options](options.md#presets) link from the browserslist section

@netlify
Copy link

netlify bot commented May 16, 2020

Deploy preview for babel ready!

Built with commit 8609c68

https://deploy-preview-2252--babel.netlify.app

@existentialism existentialism force-pushed the fix-data-link branch 2 times, most recently from ccd08ff to 69f112e Compare May 16, 2020 15:33
docs/preset-env.md Outdated Show resolved Hide resolved
Co-authored-by: Tomer Aberbach <tomeraberbach@gmail.com>
@TomerAberbach
Copy link
Contributor

Hey @existentialism! I don't mean to be a bother, but I just want to make sure you didn't miss that I wrote that the JSON syntax mistake is in the previous versions of the documentation too. If you saw that part and are just planning to update the files later, then that's fine!

@existentialism
Copy link
Member Author

@TomerAberbach yeah i'll update them, thanks

website/versioned_docs/version-7.0.0/preset-env.md Outdated Show resolved Hide resolved
website/versioned_docs/version-7.4.0/preset-env.md Outdated Show resolved Hide resolved
website/versioned_docs/version-7.8.0/preset-env.md Outdated Show resolved Hide resolved
website/versioned_docs/version-7.9.0/preset-env.md Outdated Show resolved Hide resolved
@JLHwung JLHwung merged commit a821e57 into master Aug 5, 2020
@JLHwung JLHwung deleted the fix-data-link branch August 5, 2020 21:22
JLHwung added a commit to JLHwung/babel-website that referenced this pull request Aug 5, 2020
JLHwung added a commit to JLHwung/babel-website that referenced this pull request Aug 5, 2020
JLHwung added a commit that referenced this pull request Aug 7, 2020
* Backport

* backport #2252 to 7.10.0/preset-env

* 7.11.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants