insert varchar column mismatch through INSERT INTO EXEC into a table #2017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task: BABEL-2999 Signed-off-by: Zhibai Song <szh@amazon.com>
forestkeeper
force-pushed
the
babel-2999-3
branch
from
503748e
to
db63e85
Compare
2jungkook
reviewed
Nov 14, 2023
| @@ -3047,6 +3069,210 @@ exec_stmt_insert_execute_select(PLtsql_execstate *estate, PLtsql_expr *query) | |||
| return PLTSQL_RC_OK; | |||
| } | |||
|
|
|||
| static AttrMap* build_typecast_attrmap_by_position(TupleDesc indesc, TupleDesc outdesc, const char *msg) | |||
There was a problem hiding this comment.
It seems like this is very similar to build_attrmap_by_position(). In that case, adding a special handling to the function can be better, if possible (either by adding a new hook or dialect check). If we copy engine's function, it will be not easy to adopt a new major versions when there are some changes in the original function.
added 2 commits
November 14, 2023 23:20
2jungkook
reviewed
Nov 15, 2023
2jungkook
approved these changes
Nov 15, 2023
forestkeeper
merged commit 2d20e6c
into
babelfish-for-postgresql:BABEL_3_X_DEV
28 checks passed
Closed
1 task
staticlibs
pushed a commit
to wiltondb/babelfish_extensions
that referenced
this pull request
Mar 15, 2024
Previously insert exec implement didn't consider the type cast during execution, this fix has add a implicit type cast between insert execution and exec execution if the type is mismatched. Engine pr : babelfish-for-postgresql/postgresql_modified_for_babelfish#256 Task: BABEL-2999, BABEL-4426 Signed-off-by: Zhibai Song <szh@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously insert exec impl didn't consider the type cast during execution, this fix has add a implicit type cast between insert execution and exec execution if the type is mismatched.
Task: BABEL-2999
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.