Make NEWID() and NEWSEQUENTIALID() functions VOLATILE #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 8932779828Details
💛 - Coveralls |
lejaokri
force-pushed
the
klejao-babel-4923-3x
branch
4 times, most recently
from
415564a
to
8ee4087
Compare
2jungkook
previously approved these changes
May 2, 2024
lejaokri
force-pushed
the
klejao-babel-4923-3x
branch
2 times, most recently
from
4a7f516
to
322fb0d
Compare
Altering a table to add a column with DEFAULT NEWID() makes the values all the same value which is not the correct bheaviour. This is because NEWID and NEWSEQUENTIALID are both STABLE when then should be VOLATILE. Task: BABEL-4923 Signed-off-by: Kristian Lejao <klejao@amazon.com>
lejaokri
force-pushed
the
klejao-babel-4923-3x
branch
from
322fb0d
to
2546cce
Compare
rishabhtanwar29
approved these changes
May 3, 2024
Deepesh125
approved these changes
May 3, 2024
Deepesh125
merged commit db9e465
into
babelfish-for-postgresql:BABEL_3_X_DEV
40 checks passed
staticlibs
pushed a commit
to wiltondb/babelfish_extensions
that referenced
this pull request
May 4, 2024
…postgresql#2540) Altering a table to add a column with DEFAULT NEWID() makes the values all the same value which is not the correct behaviour. This is because NEWID and NEWSEQUENTIALID are both STABLE when it should be VOLATILE. Task: BABEL-4923 Signed-off-by: Kristian Lejao <klejao@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief History
From GA to 14.6/15.1
NEWID() is VOLATILE [this is correct]
From 14.7/15.2 to 14.11/15.6
NEWID() is STABLE [this is wrong]
From 14.12/15.7
NEWID() should be VOLATILE
Description
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.