Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Websocket opcode question #52

Closed
mmardinian opened this issue Jun 26, 2018 · 3 comments
Closed

Websocket opcode question #52

mmardinian opened this issue Jun 26, 2018 · 3 comments
Labels

Comments

@mmardinian
Copy link

Hi,

Is it normal that both text and binary opcode for websocket has the same value?

#define U_WEBSOCKET_OPCODE_TEXT 0x01 #define U_WEBSOCKET_OPCODE_BINARY 0x01

Best regards,

Michael

@babelouest
Copy link
Owner

Hello @mmardinian ,

No it's not normal, U_WEBSOCKET_OPCODE_BINARY sould be 0x02 and not 0x01, thanks for pointing out.

I'll fix this ASAP in the master branch.

@babelouest babelouest added the bug label Jun 26, 2018
@mmardinian
Copy link
Author

Thank you

@babelouest
Copy link
Owner

Hello @mmardinian ,

The opcode bug has been fixed in the master branch and the new release 2.3.7.

I've made more tests with binary messages and it seems to work fine, but if you have other concerns about it, don't hesitate!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants